Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Dymo labelwriter #13492

Merged
merged 5 commits into from
Aug 18, 2023
Merged

Added Dymo labelwriter #13492

merged 5 commits into from
Aug 18, 2023

Conversation

snipe
Copy link
Owner

@snipe snipe commented Aug 18, 2023

This is an attempt to add the Dymo LabelWriter to the new label engine (#12050). This needs testing and will probably need refining, as I'm not sure I got the measurements correct, but it's at least a start.

@snipe snipe mentioned this pull request Aug 18, 2023
10 tasks
@what-the-diff
Copy link

what-the-diff bot commented Aug 18, 2023

PR Summary

  • Label Identifier Adjustment

In the LabelsController.php, the identifier for an example asset has been updated, shifting from 'AST-AB-CD-1234' to 'JEN-867-5309'. This alteration may simply be to align with new nomenclature standards or to fit a different system of asset identifiers.

  • Label Dimensions Formatting

The LabelsTransformer.php now utilizes the Number Format setting for the width and height attributes of the label object. With this formatting, these measurements should now be more appropriately and accurately represented.

  • Exception Handling Enhancement

In the Label.php file, a try-catch block has been implemented to the write1DBarcode method. This block is extremely valuable as it ensures that any potential errors that occur during this method's execution will be caught and dealt with appropriately, preventing a system crash and maintaining application stability.

  • Addition of Dymo Label Writer

A new LabelWriter.php file has been added under app/Models/Labels/Tapes/Dymo/ directory, suggesting a possible extension in the program’s label-writing capability specifically with Dymo label tapes.

  • Introduction of Dymo Label Writer 30252 Model

An additional model file, LabelWriter_30252.php, has been added to the Dymo subfolder, suggesting that the system will now support labels specific to the 'Dymo 30252' LabelWriter model.

  • Restrictions on Label Fields Sorting

Finally, in LabelPresenter.php, the sorting function has been disabled for a range of fields. Specifically fields such as 'name', 'support_fields', 'support_asset_tag', 'support_1d_barcode', 'support_2d_barcode', 'support_logo', 'support_title' will no longer be sortable. This change likely is to streamline user experience, reducing potential confusion or errors.

@snipe
Copy link
Owner Author

snipe commented Aug 18, 2023

Merging this in case anyone wants to test this on develop

@snipe snipe merged commit 2346bab into develop Aug 18, 2023
@snipe snipe deleted the features/add_dymo_labelwriter branch August 18, 2023 22:27
@timurkun
Copy link

Hi @snipe ! In this label template 1D and 2D barcodes should be shown according to the list:
image
but actually there's no 1D barcode.
As I can see in Dymo/LabelWriter_30252.php we have:
public function getSupport1DBarcode() { return true; }
but we have no code like:
static::write1DBarcode(...)
as it is in Brother/TZe_12mm_A.php

Could it be the reason why there's no 1D barcode on label and could it be fixed by adding some code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants