-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added last check in column and filter to custom asset report #13498
Added last check in column and filter to custom asset report #13498
Conversation
PR Summary
|
@@ -651,6 +655,13 @@ public function postCustom(Request $request) | |||
$assets->whereBetween('assets.last_checkout', [$checkout_start, $checkout_end]); | |||
} | |||
|
|||
if (($request->filled('checkin_date_start')) && ($request->filled('checkin_date_end'))) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's possible we might want to allow no end date, or maybe default the date to today? I could see that being an annoying process, having to pick that every time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good thinking.
On the frontend, the end date is selected when the user selects the start date but they are able to clear the date and skip passing checkin_date_end
to the backend.
I just pushed a commit that handles that situation.
@snipe friendly ping to check out my changes. |
Description
This PR adds the
Last Checkin Date
column andLast Checkin Date
range filter to the Custom Asset Report:The column displays the date and time the asset was last checked in and the filter allows for only returning items that were last checked in during range. Since we are only searching the last check in, an asset that was checked in during the range but then checked out and checked in outside of the range, it will not be included.
One question: Should the label be
Last Checkin Date
(which matches the labels below it),Last Checkin Date Range
(which matches the labels above, or should I update the labels to all have Range?Closes: Shortcut Story #23356: Add check in date range filter on the custom asset report
Follows up on #13323
Type of change