Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Not reassignable Licenses shouldn't show 'Checkin All Seats' button [sc-23506] #13520

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

inietov
Copy link
Collaborator

@inietov inietov commented Aug 24, 2023

Description

Following on some freshdesk I think I discovered an issue.

If the license is reassignable, it should let checkout and checkin as much as the user with proper permissions wants.
I the license is not reassignable, it let the user checkout every seat, but not checkin as the license can't be assigned to anyone else.

So the 'Checkin All Seats' option should be disabled if license is not reassignable, which is not the case right now. I modified the LicenseCheckinController so it now evaluates first if the License is reassignable or not, which shouldn't be necessary since I also disable the button in the view, but just to be sure.

Also, as mentioned, I edit the view to disable the 'Checkin All Seats' button if the License is not reassignable. I don't love that I repeated a lot of code in the new condition of the blade, but I wanted to show in a tooltip why the button is disabled. If is beacuse of the License not being reassignable:

image

And if no License seat is checked out:

image

Fixes kinda [sc-23506]

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test Configuration:

  • PHP version: 8.1
  • MySQL version: 8.0.31
  • Webserver version: PHP dev server
  • OS version: Debian 11

@shortcut-integration
Copy link

@what-the-diff
Copy link

what-the-diff bot commented Aug 24, 2023

PR Summary

  • Enhanced License Check-in Functionality
    A new verification step has been introduced in the license management system. This addition ensures that licenses can only be checked-in if they are reassignable, increasing control and preventing errors.

  • Updates to Language File
    The textual content for disabled tooltips in the system has been revised for clarity and context, which helps users understand better why certain options might be unavailable to them.

  • Improved User Interface
    The license management user interface has been updated. Now, the check-in button will be in a disabled state if a non-reassignable license is selected, providing a more intuitive user experience.

@inietov
Copy link
Collaborator Author

inietov commented Aug 24, 2023

Sorry for the super-big images :S

@snipe
Copy link
Owner

snipe commented Aug 28, 2023

I think you should still be allowed to check them in, you just shouldn't be allowed to check them back out, no?

@marcusmoore
Copy link
Collaborator

This is on my radar but gonna hold off on reviewing until @snipe's question is answered. (I don't have a solid answer either way)

Copy link
Collaborator

@marcusmoore marcusmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise this looks good.

@snipe it looks like we don't currently allow checking in individual licenses that aren't re-assignable so this change brings the bulk check-in inline with what exists.

license not able for check in

@snipe snipe merged commit b92327e into snipe:develop Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants