Fixed Not reassignable Licenses shouldn't show 'Checkin All Seats' button [sc-23506] #13520
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following on some freshdesk I think I discovered an issue.
If the license is reassignable, it should let checkout and checkin as much as the user with proper permissions wants.
I the license is not reassignable, it let the user checkout every seat, but not checkin as the license can't be assigned to anyone else.
So the 'Checkin All Seats' option should be disabled if license is not reassignable, which is not the case right now. I modified the LicenseCheckinController so it now evaluates first if the License is reassignable or not, which shouldn't be necessary since I also disable the button in the view, but just to be sure.
Also, as mentioned, I edit the view to disable the 'Checkin All Seats' button if the License is not reassignable. I don't love that I repeated a lot of code in the new condition of the blade, but I wanted to show in a tooltip why the button is disabled. If is beacuse of the License not being reassignable:
And if no License seat is checked out:
Fixes kinda [sc-23506]
Type of change
How Has This Been Tested?
Test Configuration: