Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed undeclared variable in ActionlogsTransformer #13525

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

marcusmoore
Copy link
Collaborator

Description

This PR fixes a bug where the $clean_logs variable might not be defined in the ActionlogsTransformer.

Even though the if statement on line 50 seems to guard against this, if the log_meta column contains {} then it will evaluate to true but not enter the if block on line 53 (line 55 in this PR).

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #23660: ErrorException: Undefined variable $clean_meta.

@what-the-diff
Copy link

what-the-diff bot commented Aug 24, 2023

PR Summary

  • Introduction of a new variable
    A new variable named $clean_meta has been introduced in the ActionlogsTransformer.php file. This variable is designed to hold processed data.

  • Updated Logic for $clean_meta
    The way data is gathered and organized for the $clean_meta variable has been tweaked, aiming to enhance data handling in the system.

  • Modification of the transformActionlog Function
    The function transformActionlog that plays a key role in manipulating action logs has been updated to utilize our newly added variable $clean_meta. This change was made to improve the efficiency of action log transformations within the system.

@snipe snipe merged commit 26dd992 into snipe:develop Aug 24, 2023
@marcusmoore marcusmoore deleted the bug/sc-23660 branch August 24, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants