-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added threshold notifications and min qty for Asset models #13526
Conversation
PR Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we also need to add min_amt
to the fillable
array in the AssetModel
model since we use $assetmodel->fill($request->all());
in the API, otherwise additions/updates via the API won't be able to access that value. (Unless it's already in there and I just missed it.)
Otherwise this looks pretty solid.
Not for this PR, but we should also see about adding models to the inventory alert emails.
|
Ah, you're right, my bad. The GH diff made it look weird. If you can yank those commented lines out, this looks good to go. |
Looks like we have a merge conflict now |
Nice, quick as a bunny :) |
The chipper test is failing on this, but I think it's related to an earlier merge. |
Description
This adds a minimum quantity threshold for Asset Models. Also updates the notifcations to include Asset Models.
Fixes #sc-19826
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: