Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Dusk #13550

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Removed Dusk #13550

merged 1 commit into from
Aug 31, 2023

Conversation

marcusmoore
Copy link
Collaborator

@marcusmoore marcusmoore commented Aug 30, 2023

Description

This PR removes, at least for now, Laravel Dusk since it is not being used locally or in CI.


Note: Dusk is mentioned in our upgrade script but I don't think the conditional should be changed. Maybe I should just remove the references to Dusk?

snipe-it/upgrade.php

Lines 72 to 84 in a9d175a

* because the Dusk service provider only tries to load if the app is not in production mode.
*
* It's 100% okay if they're not in production mode, but this will avoid any confusion as they get
* erroneous errors using this upgrader if they are not in production mode when they run this script.
*
* We use this further down in the composer section of this upgrader.
*/
if ($env_key == "APP_ENV") {
if ($env_value == 'production') {
$app_environment = 'production';
}
}

@marcusmoore marcusmoore requested a review from snipe as a code owner August 30, 2023 23:44
@probot-autolabeler probot-autolabeler bot added backend dependencies Pull requests that update a dependency file tests labels Aug 30, 2023
@what-the-diff
Copy link

what-the-diff bot commented Aug 30, 2023

PR Summary

  • Removal of the dusk service
    This change consists of the elimination of the dusk service from our CI/CD configuration file.
  • Update of the .gitignore File
    Specific environment settings files used for the dusk service have been removed. However, the example file was kept, allowing other developers to understand the expected format.
  • Update of Testing Documentation
    The section dedicated to Browser Tests has been taken out because we're no longer using the dusk service.
  • Changes in AppServiceProvider.php
    The DuskServiceProvider is no longer registered in the AppServiceProvider file. This means that we stopped using dusk's specific services within our application.
  • Update of composer.json
    The "laravel/dusk" dependency has been removed from the require-dev section of composer.json as we no longer require this package for our development environment.
  • Deletion of Specific Testing Files
    Several Dusk-related files including tests, pages, and certain gitignore files have been deleted since they are no longer needed with the removal of the Dusk service. This makes our code simpler and more focused.

@snipe
Copy link
Owner

snipe commented Aug 31, 2023

I left the existing tests in there so we could (if we wanted to) use them as a guideline, but I'm fine with trashing them.

@snipe snipe merged commit e192cbb into snipe:develop Aug 31, 2023
@marcusmoore marcusmoore deleted the remove-dusk branch August 31, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend dependencies Pull requests that update a dependency file tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants