Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Unaccepted Assets report has incorrect people [freshdesk-37808] #13574

Merged

Conversation

inietov
Copy link
Collaborator

@inietov inietov commented Sep 7, 2023

Description

When an asset is checked out to a location or another asset and requires users to accept them, they appear in the Unaccepted Assets report and tries to show the user they have assigned, which is incorrect because those entities can't accept an asset.

Notifications aren't sent, so I just filter those acceptances to not appear in the report if they aren't assigned to users.

Fixes freshdesk #37808

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test Configuration:

  • PHP version: 8.1
  • MySQL version: 8.0.31
  • Webserver version: PHP Dev Server
  • OS version: Debian 12

@what-the-diff
Copy link

what-the-diff bot commented Sep 7, 2023

PR Summary

  • Added Asset Filtering Condition in Reports
    The update for the 'ReportsController.php' includes a new addition made to filter assets. Now, the system will be checking if the assets being included in a report are currently checked out to a user. This change ensures that only relevant assets are presented in the report, providing a more accurate and concise overview.

@snipe
Copy link
Owner

snipe commented Sep 7, 2023

This looks nice and straightforward, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants