Standardize Asset EOL Date

[spencerrlongg]

Description

Second attempt at this PR after blowing up the first attempt with a rebase.

This should help us get to more of a denormalized Asset EOL Date, and hopefully remove the need for any on-the-fly calculation of that date. The migration calculates and updates all fields where possible, and the observer and asset model controller should always make sure that the value is calculated when it can be. Furthermore, this adds an eol_explicit column to Assets to indicate when asset_eol_date does not match what the calculated date would be.

On the frontend the only change of note is adding an indicator that the asset_eol_date is explicitly set (or differing from what would be calculated)

Type of change

• New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• API
• GUI
• Importer

Test Configuration:

• PHP version: 8.1
• MySQL version 8.1

Checklist:

• I have read the Contributing documentation available here: https://snipe-it.readme.io/docs/contributing-overview
• I have formatted this PR according to the project guidelines: https://snipe-it.readme.io/docs/contributing-overview#pull-request-guidelines
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[what-the-diff]

PR Summary

• Enhancement of Asset Lifecycle Management
  In AssetModelsController.php and AssetsController.php, the logic has been updated to better handle the lifecycle data of the assets (asset_eol_date and eol fields). This includes an improved method to store and update lifecycle information. This will enable more accurate and reliable lifecycle management for the assets.

• Update on Data Importing Features
  In the Importer.php, and AssetImporter.php, the ability to import asset_eol_date, an important lifecycle date for assets, has been added which will make data imports more detailed and useful.

• Commented-out Logic in ItemImporter.php
  The logic related to asset_eol_date in ItemImporter.php has been commented out as it is currently not needed. This means asset_eol_date won't be processed when importing items data.

• Improvement on Asset's Data Structure
  In Asset.php, the data structure for assets has been improved - new rules have been introduced, and certain data types have been explicitly defined. This will ensure a more uniform data structure for assets, and prevent potential inconsistencies.

• Enhancements in Asset Presentation
  In AssetPresenter.php, the method of computing the eol_date (end of life date) for assets has been refined. This now offers a more accurate representation of asset lifecycle data.

• Update on Test Data Generation
  In AssetFactory.php, the logic to generate test data has been updated to include asset_eol_date, thereby providing a more comprehensive dataset for testing.

• Database Update with Migration
  A new migration file has been added which introduces a new field (eol_explicit) and modifies an existing field (asset_eol_date). This will better accommodate the updated asset management functionality while ensuring the integrity of existing data.

[marcusmoore]

FYI: I started reviewing this and will wrap up tomorrow.

[marcusmoore]

Thanks for all of the effort put into this. I know it was a heavy lift.

I ran into some exceptions while testing it out that we gotta address before merging 😕

[marcusmoore]

Looks good! 😄