-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify upload messaging, handle -1% error #13605
Conversation
Signed-off-by: snipe <[email protected]>
This pull request has been linked to Shortcut Story #23183: Import upload -1% error message. |
PR Summary
|
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
Signed-off-by: snipe <[email protected]>
(Okay, I'm done for real now lol) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Some really nice improvements - the :
thing was particuarly subtle. Good choice.
This doesn't really fix the issue as such, but it makes it look less terrible and confusing. I don't think the % uploaded ever actually worked properly (or files uploaded fast enough that we never saw the % increase). We can always revisit this and try to get the % actually working correctly if we want to.
Screen.Recording.2023-09-14.at.9.54.19.PM.mov