-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added column re-ordering #13613
Added column re-ordering #13613
Conversation
Signed-off-by: snipe <[email protected]>
PR Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The quirks you mentioned are valid but I hope the ability to arrange columns overcomes them. (I wasn't able to trigger the wrong values being displayed after re-ordering)
It's also a little annoying that when you click on the column header to re-order it, it also re-sorts it, but I'm not sure if there's a way around this.
This didn't seem to happen for me in Brave FWIW. I'm using an Apple Trackpad that doesn't require actually clicking to drag though so maybe that was the key?
Huh. I'm using my trackpad on my MacBook Pro. I tested on Safari and Firefox (and I think Chrome). |
As I mentioned on the dev call today, I might feel better making this something the user can turn off, just in case it's frustrating to them. That might come later though, depending on user feedback. |
Hm...I'm using an Apple Magic Trackpad but that shouldn't make a difference... CleanShot.2023-09-18.at.12.55.11.mp4
I think that's a pretty good idea... |
This is an experimental branch that adds the long-requested column re-ordering functionality. I've tried this before with mixed results, but I think BS tables and some of the extensions associated may have improved over time.
Shorter tables:
Screen.Recording.2023-09-15.at.10.02.37.PM.mov
Longer tables with sticky header:
Screen.Recording.2023-09-15.at.10.04.46.PM.mov
I have noticed a few times where the wrong values are displaying when a column is moved, as if it remembers the value of the column but only moves the header. It's hard to reproduce though. :-/ (This is similar to what I ran into the last time I tried this. It's fixable by moving the column again, but it might be too annoying to users to keep this feature.)
It's also a little annoying that when you click on the column header to re-order it, it also re-sorts it, but I'm not sure if there's a way around this.
If you're wondering why we're not using the node modules, it's because the drag table and re-sort libraries
haven't had a releasehaven't been updated in npm in quite some time (they have tagged releases), and the highest I can get from npm is 2.0.12, while the latest is 2.0.15. :(