Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unique() to some factory properties #13635

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

marcusmoore
Copy link
Collaborator

Description

This PR adds the unique() modifier to a few factory properties that need to be unique.

This should fix the very rare occurrence of incorrect test failures.

Type of change

  • Bug fix (non-breaking change which fixes an issue) ❓

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #23715: Fix flaky webhook tests.

@what-the-diff
Copy link

what-the-diff bot commented Sep 20, 2023

PR Summary

  • Enhanced Uniqueness in the 'Name' Field Among Various Factories
    The field for 'name' in multiple areas like Company, Custom Field, Custom Fieldset, Depreciation, and Manufacturer has been altered. A unique value generated by Faker->catchPhrase() is now used, enhancing the distinctiveness and reducing any overlaps.

  • Unique Username Creation in UserFactory
    The 'username' field within the UserFactory has been reformed. It now leverages Faker->username() to create unique usernames, thereby improving the system's way of identifying and managing users.

@snipe snipe merged commit 46981da into snipe:develop Sep 20, 2023
@marcusmoore marcusmoore deleted the bug/sc-23715 branch September 20, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants