Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fieldset Properly Sortable in Asset Models Table #13678

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

spencerrlongg
Copy link
Collaborator

Description

Pretty straightforward, what it says on the tin - adds a scope to the AssetModel model for sorting the Fieldset properly on the Asset Model table.

Fixes https://app.shortcut.com/grokability/story/23596/ascending-descending-sort-for-fieldsets-in-the-models-table-not-working

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Table Tested

Test Configuration:

  • PHP version: 8.1
  • MySQL version 8.1

@shortcut-integration
Copy link

@what-the-diff
Copy link

what-the-diff bot commented Sep 28, 2023

PR Summary

  • Addition of fieldset feature
    A new feature called fieldset has been introduced into AssetModelsController.php. This adds more flexibility and eases information filtering.

  • Enhancement in sorting methodology
    The system now has an updated method to sort data, making it easier and quicker to find relevant information. This is made possible by the newly added option in the AssetModelsController.php.

  • New method in AssetModel.php
    The inclusion of the method scopeOrderFieldset in AssetModel.php expands the capability of the model, thus enhancing the functionality of the system.

  • Improved ordering mechanism
    The method scopeOrderFieldset also ensures better data presentation by joining the custom_fieldsets table and arranging the name column in either ascending or descending order, as per requirements. This provides a more user-friendly interface.

@snipe snipe merged commit f16e81e into snipe:develop Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants