Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom fields on user v7 #13715

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Custom fields on user v7 #13715

wants to merge 8 commits into from

Conversation

uberbrady
Copy link
Collaborator

This is a version of the HasCustomFields Trait and Custom fields for Users change, but rebased to be able to land on the new Snipe-IT v7.

@what-the-diff
Copy link

what-the-diff bot commented Oct 5, 2023

PR Summary

  • Added Custom Field Handling Functionality
    A new helper file was added to improve the way we work with custom fields, making it more efficient. This addition influenced many other changes.

  • Improved Data Filling Method
    The methods for storing and updating data have been improved. This not only affects items, but users and models as well. The improvements should help to make these operations more efficient and less prone to errors.

  • Enhanced Fieldset Configuration
    The enhancements in fieldset configuration mean users now have a default fieldset. The process of creating and assigning fields to fieldsets has also been optimised.

  • Added Custom Field to Asset Presentation
    Custom fields have now been integrated into the presentation of assets. This means they will now show up when viewing the information relating to any asset.

  • Improved Custom Field Handling in Models
    A new trait has been added that improves the way custom fields are handled in the models. This has been applied to the User model which should improve performance when dealing with custom fields.

  • Applied Changes to Testing
    Files related to testing have been adapted to account for the new way we're managing fields. This maintains high standards of quality as we continue to ensure that our software works as expected.

  • Improved Proxy Handling
    The handling of trusted proxy headers has been changed. This shouldn't affect the user but is important for maintaining the security and reliability of the software.

  • Updated Database Structure
    We've updated our database structure to account for the new "type" columns. This will allow us to handle different types of data more effectively.

  • Enhanced User Interface
    The user interface (UI) has gone through changes to accommodate the new custom filed handling. This should make for a smoother, more intuitive experience when dealing with items in the system.

  • Significant Testing Improvements
    To ensure the reliability of the new features, our testing procedures have been significantly improved. This helps identify and fix any issues early, before they become problems for users.

uberbrady added 7 commits June 6, 2024 13:35
…the new HasCustomFields trait.

This should allow us to add custom fields to just about anything we want to within Snipe-IT.

Below are the commits that have been squashed together:

Initial decoupling of custom field behavior from Assets for re-use

Add new DB columns to Custom Fields and fieldsets for 'type'

WIP: trying to figure out UI for custom fields for things other than Assets, find problematic places

Real progress towards getting to where this stuff might actually work...

Fix the table-name determining code for Custom Fields

Getting it closer to where Assets at least work

Rename the trait to it's new, even better name

Solid progress on the new Trait!

WIP: HasCustomFields, still working some stuff out

Got some basics working; creating custom fields and stuff

HasCustomFields now validates and saves

Starting to yank the other boilerplate code as things start to work (!)

Got the start of defaultValuesForCustomField() working

More progress (squash me!)

Add migrations for default_values_for_custom_fields table

WIP: more towards hasCustomFields trait

Progress cleaning up the PR, fixing FIXME's

New, passing HasCustomFieldsTrait test!

Fix date formatter helper for custom fields

Fixed more FIXME's
@uberbrady uberbrady force-pushed the custom_fields_on_user_v7 branch from a00ecd7 to 3a3f26b Compare June 6, 2024 12:57
@uberbrady uberbrady changed the base branch from snipeit_v7_laravel10 to develop June 6, 2024 12:58
@snipe
Copy link
Owner

snipe commented Jan 16, 2025

@uberbrady Should I close this one, since you have #8263?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants