-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added #14230: Add option to deactivate expected checkin notifications for users #14497
base: develop
Are you sure you want to change the base?
Added #14230: Add option to deactivate expected checkin notifications for users #14497
Conversation
add condition to check if checkin_notification_user setting is active to SendExpectedCheckinAlerts.php
PR Summary
|
Thanks for this. Please remove the German translation file from this PR, as we use CrowdIn and the change you made will just be lost the next time we pull down translations. I'm mostly loathe to add yet another setting option to be honest. We're working on revamping how notifications work, and I'm afraid this might just add more complexity down the line as we have to forklift existing functionality. I will discuss with the team internally. |
No problem, the German language strings are removed. |
Hey, that would be nice to have. Has a decision been made yet as to whether it will be implemented? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to change the DB default in that migration to 1, since this would break existing functionality.
Description
This pull request adds a setting in the form of a checkbox to the general settings page. When this is checked, the user and admin will receive an email if the check-in of an asset is expected/overdue. However, if the checkbox is not activated, only the admin will receive the notification that the return of an asset is expected or overdue.
This change affects the
php artisan snipe-it:expected-checkin
command.Language strings for German and US-English and the migration file for the database are included.
Fixes #14230
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Test Configuration:
Checklist: