Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed "Edit Your Profile" button from View Assets page if user is not able to edit their profile #14999

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

marcusmoore
Copy link
Collaborator

Description

This PR follows up #14951 by removing the Edit Your Profile on the view-assets page if self-profile-editing is disabled.

Before
Before with Edit Your Profile button still on page

After
After with Edit Your Profile button removed from page

Fixes #14993

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Copy link

what-the-diff bot commented Jul 1, 2024

PR Summary

  • Improved User Authorization Check
    This update includes a new provision that double checks whether a user has appropriate permissions to modify their personal profile, before presenting them with the option to do so. This enhancement essentially provides an extra layer of security and organization in the user interface.

@snipe
Copy link
Owner

snipe commented Jul 1, 2024

Duh, thank you. Great catch.

@snipe snipe merged commit d2df83c into snipe:develop Jul 1, 2024
8 of 9 checks passed
@marcusmoore marcusmoore deleted the fixes/hide-edit-profile-button branch July 1, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants