Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a coupled test namespaces #15110

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

marcusmoore
Copy link
Collaborator

Description

This PR fixes a couple bad mis-spelled namespaces I noticed on composer install:

Class Tests\Feature\Department\Api\CreateDepartmentsTest located in ./tests/Feature/Departments/Api/CreateDepartmentsTest.php does not comply with psr-4 autoloading standard (rule: Tests\ => ./tests). Skipping.
Class Tests\Feature\AssetModels\Ui\IndexLocationsTest located in ./tests/Feature/Locations/Ui/IndexLocationsTest.php does not comply with psr-4 autoloading standard (rule: Tests\ => ./tests). Skipping.

The tests would still run but this PR just rids of the warning.

Type of change

  • Bug fix (non-breaking change which fixes an issue) (ish)

@marcusmoore marcusmoore requested a review from snipe as a code owner July 17, 2024 18:07
Copy link

what-the-diff bot commented Jul 17, 2024

PR Summary

  • Refactoring Test Namespaces
    The code changes in this PR mainly revolve around organizing the tests more accurately. The modification of the namespaces in the test files CreateDepartmentsTest.php and IndexLocationsTest.php is to improve the way we categorize and locate our tests, ensuring they align with the correct features they are testing. This makes the test suite easier to navigate and maintain, ultimately leading to better code quality and efficiency in addressing potential issues.

@snipe snipe merged commit 8e60a7b into snipe:develop Jul 18, 2024
9 checks passed
@snipe
Copy link
Owner

snipe commented Jul 18, 2024

Danke!

@marcusmoore marcusmoore deleted the fixes/test-namespace-fixes branch July 18, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants