FEATURE: Option for Notes to be Required on Asset Checkin/Checkout #15208

akemidx · 2024-08-01T21:10:58Z

Description

This adds an option in the admin settings to turn on whether the Notes field is required on the asset checkin/checkout screens.

26415

Type of change

Please delete options that are not relevant.

New feature (non-breaking change which adds functionality)

Checklist:

I have read the Contributing documentation available here: https://snipe-it.readme.io/docs/contributing-overview
I have formatted this PR according to the project guidelines: https://snipe-it.readme.io/docs/contributing-overview#pull-request-guidelines
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes

what-the-diff · 2024-08-01T21:11:20Z

PR Summary

Addition of New Settings Option
A new setting option, named require_checkinout_notes, has been included. This will allow for more detailed check-in or check-out notes, which can be useful for precise tracking and record-keeping.
Configuration Changes
The settings controller has been adjusted to incorporate the new require_checkinout_notes setting. These changes facilitate the control of this newly-introduced option.
Language File Update
Updates have been made to a language file (general.php), including incorporating the new require_checkinout_notes setting. This allows for the new setting to be properly labeled and described.
Interface Changes for Check-in/Check-out
Depending on whether the require_checkinout_notes setting is enabled, the check-in and check-out interfaces have been altered to include a text area for notes. This allows the user to provide detailed notes during check-in or check-out if the option is activated.
Settings Interface Update
The settings interface has been updated to allow users to easily enable or disable the require_checkinout_notes setting. The update includes the addition of a checkbox for effortless toggling.

marcusmoore

Solid work overall 👍🏾

I didn't actually pull this down but have a couple ideas. Only the default value for require_checkinout_notes is one something I'm feeling strongly about.

database/migrations/2024_08_01_201721_add_required_notes_setting.php

resources/views/hardware/checkout.blade.php

snipe

Just the few small things in the comments

snipe · 2024-08-20T18:27:13Z

@akemidx - any progress on this one?

akemidx · 2024-08-20T18:47:30Z

doing this one today

…added

akemidx · 2024-09-04T22:29:32Z

validation added, but now some tests are failing. looks like something to do with delete user.

there is front end validation, in which the note field can't be empty, so that's squared away. just need to get the rest working

marcusmoore

Looking good so far but a few minor changes por favor.

database/migrations/2024_08_01_201721_add_required_notes_setting.php

app/Http/Controllers/Assets/AssetCheckinController.php

app/Http/Requests/AssetCheckinRequest.php

marcusmoore · 2024-10-01T23:38:04Z

app/Http/Controllers/Assets/AssetCheckoutController.php

+            if($settings->require_checkinout_notes=="1" && (is_null($request->note))) {
+                   return redirect()->to("hardware/$assetId/checkout")->with('error', trans('admin/hardware/message.update.no_note'));
+            }
+


Same comment as above but it'll go in AssetCheckoutRequest.

…added

…c-26415 # Conflicts: # app/Http/Controllers/Assets/AssetCheckinController.php # app/Http/Controllers/Assets/AssetCheckoutController.php # app/Http/Requests/AssetCheckinRequest.php

snipe · 2024-10-07T11:37:23Z

😬

Looks like you've got some failing tests too.

resources/views/hardware/checkin.blade.php

marcusmoore

One changed needed for validation

app/Http/Requests/AssetCheckinRequest.php

resources/lang/en-US/admin/hardware/message.php

snipe · 2024-11-26T20:10:59Z

This looks great - nice work!

akemidx added 3 commits August 1, 2024 16:06

required, but not optional

552f90a

setting created

3ff1745

note field optional

0f0baa2

akemidx requested a review from snipe as a code owner August 1, 2024 21:10

probot-autolabeler bot added backend frontend translations labels Aug 1, 2024

marcusmoore requested changes Aug 5, 2024

View reviewed changes

database/migrations/2024_08_01_201721_add_required_notes_setting.php Outdated Show resolved Hide resolved

resources/views/hardware/checkout.blade.php Outdated Show resolved Hide resolved

snipe requested changes Aug 13, 2024

View reviewed changes

Merge remote-tracking branch 'upstream/develop' into feature/sc-26415

4e43fa6

akemidx added 5 commits August 20, 2024 19:07

front end changes/updates from gh

27c120a

more test work

2901ecb

fixing some formatting

77c5035

back to having tests pass. needed to comment out the notes rules() i …

bebb72a

…added

backend form validation. +cleanup

d262638

missing closing )

73a059c

akemidx requested a review from marcusmoore October 1, 2024 20:45

marcusmoore requested changes Oct 1, 2024

View reviewed changes

akemidx added 8 commits October 2, 2024 18:15

required, but not optional

081c570

setting created

700647c

note field optional

8b643cb

front end changes/updates from gh

5e74b10

more test work

515f59f

fixing some formatting

bd6698d

back to having tests pass. needed to comment out the notes rules() i …

925aea8

…added

backend form validation. +cleanup

f45b836

akemidx added 5 commits October 2, 2024 18:15

missing closing )

6fef127

requested changes

17706f1

Merge remote-tracking branch 'origin/feature/sc-26415' into feature/s…

492e686

…c-26415 # Conflicts: # app/Http/Controllers/Assets/AssetCheckinController.php # app/Http/Controllers/Assets/AssetCheckoutController.php # app/Http/Requests/AssetCheckinRequest.php

requested changes

06e3bb7

note box is now missing when unchecking setting

e00a1ae

akemidx requested a review from uberbrady as a code owner October 2, 2024 22:52

un'required'ing the rule. not sure what's breaking here but looking

0c84904

akemidx added 3 commits October 8, 2024 15:51

weird requesting

299e743

Merge branch 'refs/heads/upstream/dev' into feature/sc-26415

5cb940c

removing some comments/merging in develop

f0d3a6e

uberbrady reviewed Nov 12, 2024

View reviewed changes

resources/views/hardware/checkin.blade.php Outdated Show resolved Hide resolved

removing required form div container

9cb411c

akemidx requested a review from marcusmoore November 13, 2024 23:47

akemidx added 2 commits November 21, 2024 19:01

commit for testing

dd223fc

orange bar for requirednessness

0d60855

marcusmoore requested changes Nov 22, 2024

View reviewed changes

app/Http/Requests/AssetCheckinRequest.php Outdated Show resolved Hide resolved

resources/lang/en-US/admin/hardware/message.php Outdated Show resolved Hide resolved

akemidx added 2 commits November 26, 2024 15:04

requested changes from pr

2727210

fixing line

a7dae10

akemidx requested a review from marcusmoore November 26, 2024 20:10

snipe merged commit 82108f8 into snipe:develop Nov 26, 2024
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FEATURE: Option for Notes to be Required on Asset Checkin/Checkout #15208

FEATURE: Option for Notes to be Required on Asset Checkin/Checkout #15208

akemidx commented Aug 1, 2024

what-the-diff bot commented Aug 1, 2024

marcusmoore left a comment

snipe left a comment

snipe commented Aug 20, 2024

akemidx commented Aug 20, 2024

akemidx commented Sep 4, 2024

marcusmoore left a comment

marcusmoore Oct 1, 2024

snipe commented Oct 7, 2024

marcusmoore left a comment

snipe commented Nov 26, 2024

FEATURE: Option for Notes to be Required on Asset Checkin/Checkout #15208

FEATURE: Option for Notes to be Required on Asset Checkin/Checkout #15208

Conversation

akemidx commented Aug 1, 2024

Description

Type of change

Checklist:

what-the-diff bot commented Aug 1, 2024

PR Summary

marcusmoore left a comment

Choose a reason for hiding this comment

snipe left a comment

Choose a reason for hiding this comment

snipe commented Aug 20, 2024

akemidx commented Aug 20, 2024

akemidx commented Sep 4, 2024

marcusmoore left a comment

Choose a reason for hiding this comment

marcusmoore Oct 1, 2024

Choose a reason for hiding this comment

snipe commented Oct 7, 2024

marcusmoore left a comment

Choose a reason for hiding this comment

snipe commented Nov 26, 2024