Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout-to fixer #15266

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Checkout-to fixer #15266

merged 3 commits into from
Aug 12, 2024

Conversation

uberbrady
Copy link
Collaborator

It was briefly possible to set an assigned_to without an assigned_type within the API.

Once that happens, looking at those assets may generate a 500 error.

This tries to fix assigned_type by looking at the action_logs. While it's tempting to do a full fixup of assigned_to and assigned_type based on the action_logs, this instead just handles when assigned_type is NULL, or when assigned_to should be set to NULL.

I tried to write some tests to back this up, but they aren't working at all. I have no idea why.

If we're okay with merging this without tests, I'll take it out of draft. If not, maybe @marcusmoore can help me figure out why my tests don't seem to work?

Copy link

what-the-diff bot commented Aug 12, 2024

PR Summary

  • New Command File Added
    A new file called FixupAssignedToWithoutAssignedType.php has been added into the system. This new addition is making our system more efficient by executing specific tasks under the console.

  • New Test File Added
    An additional file called FixupAssignedToAssignedTypeTest.php has been added. This is a test file that ensures the functionality of our already existing and new features are working as expected. This maintains our commitment to high-quality software.

@snipe
Copy link
Owner

snipe commented Aug 12, 2024

I'm okay accepting this without tests, but let's see if we can't figure out why they're failing on the dev call tonight.

@snipe snipe marked this pull request as ready for review August 12, 2024 15:34
@snipe snipe self-requested a review as a code owner August 12, 2024 15:34
@snipe snipe merged commit 9d354ca into snipe:develop Aug 12, 2024
8 of 9 checks passed
@marcusmoore marcusmoore mentioned this pull request Aug 13, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants