Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the acceptance-reminder command #15375

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

Godmartinz
Copy link
Collaborator

@Godmartinz Godmartinz commented Aug 22, 2024

Description

Fixed the acceptance-reminder command. it was looking for the wrong columns. Now it looks to make sure the accepted_at and declined_at are both null before sending a reminder.

Fixes #15370

Type of change

Please delete options that are not relevant.

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

Copy link

what-the-diff bot commented Aug 22, 2024

PR Summary

  • Enhancement in Query Conditions
    The conditions within our query for executing the SendAcceptanceReminder command have been improved. There are now checks in place to see if certain statuses (namely accepted_at and declined_at) are null.

  • Improved Data Relationships
    There is also an update to the with method, now incorporating the checkoutable.admin relation. This ensures that we have all necessary administrative information attached to the checkoutable object.

  • Implication on Data Retrieval
    It's important to note that these changes will influence the outcome when we retrieve (get) information pertaining to the acceptance reminder functionality. This should streamline our current processes and mitigate potential missing data issues.

@snipe snipe merged commit cc2c8f7 into snipe:develop Aug 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants