Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed login success message not being displayed #15474

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

marcusmoore
Copy link
Collaborator

Description

This PR fixes a small bug where the "Success: You have successfully logged in." message was not shown for non-admin users after login.

Before:
message is not displayed on landing page

After:
message is displayed on landing page

Fixes [sc-26730]

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Copy link

what-the-diff bot commented Sep 9, 2024

PR Summary

  • Addition of Session Facade in Dashboard Controller
    The software now includes a new component, namely Session Facade, in the Dashboard Controller. This allows the software to manage and maintain user-specific data for the duration of their visit.

  • Reflashing session data post condition handling
    There is a new process added that 'reflashes' or recycles data from the session after a particular condition (here else situation) is handled. This helps in making sure that no useful data gets lost abruptly and can be used where required later in the session.

@snipe snipe merged commit 82e56c6 into snipe:develop Sep 10, 2024
9 checks passed
@snipe
Copy link
Owner

snipe commented Sep 10, 2024

Thanks! No idea how we missed that the first time

@marcusmoore marcusmoore deleted the bug/sc-26730 branch September 10, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants