Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Indentation in UsersController #15782

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

Toreg87
Copy link
Contributor

@Toreg87 Toreg87 commented Nov 7, 2024

Description

The indentation in the update-function of the UsersController is partially wrong. Fix this to avoid confusion.

The indentation in the update-function of the UsersController is partially wrong.
Fix this to avoid confusion.
@Toreg87 Toreg87 requested a review from snipe as a code owner November 7, 2024 08:25
Copy link

what-the-diff bot commented Nov 7, 2024

PR Summary

  • Improved Readability of Code: We have restructured the code in the update method of UsersController.php for a more clean and simplified look. This serves to make the code more understandable and manageable.
  • Optimized Authorization Process: We made adjustments in how the system verifies if a user is a superuser. This now follows a more uniform pattern which offers stability and reduces chances of errors.
  • Maintained Existing Functions: We ensured that the avatar images and session data management remain unaffected while enhancing the clarity of the code. This means you can continue to access these functionalities without any hiccups.
  • Smooth User Experience: We improved the flow of operations around saving user data and routing users based on successful or failed actions. This ensures seamless interaction with the application, increasing user satisfaction.

@snipe snipe merged commit 73383c6 into snipe:develop Nov 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants