Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed license serial gate in markdown #15805

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

Godmartinz
Copy link
Collaborator

Description

This adds a terenary on the license_seat->user gate check in the markdown for license serials

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

@Godmartinz Godmartinz requested a review from snipe as a code owner November 13, 2024 20:00
Copy link

what-the-diff bot commented Nov 13, 2024

PR Summary

  • Enhanced Security Checks in User Access
    Updated the process to verify user access in both checkin-license.blade.php and checkout-license.blade.php files to include null safety. This means the system is now better equipped to handle cases where user doesn't exist, thus preventing potential errors. It's a step towards more robust and error-free software.

@snipe
Copy link
Owner

snipe commented Nov 13, 2024

Thanks @Godmartinz - can you tell me what specific problem this was solving?

@Godmartinz
Copy link
Collaborator Author

@snipe When a license is checked out to an asset and that asset does not have an assigned_to user... that would make the license_seat->user check fail causing an exception with the markdown.

@snipe
Copy link
Owner

snipe commented Nov 13, 2024

Ah, is this why that one user wasn't getting their license checkout emails?

@Godmartinz
Copy link
Collaborator Author

undecided, but possibly? This was a bug found in the process of debugging. But there is a chance that it was messing up the mail function as a whole for licenses. Would like to merge this and retest on their instance. Continuing to explore other ways the license to user checkout email could be messing up though.

@snipe snipe merged commit ab2e7a3 into snipe:develop Nov 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants