Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for whitespace causing HTTP 500 errors. #15807

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

DarrenRainey
Copy link
Contributor

Description
Patch that adds qoutes around MAIL_FROM_NAME and MAIL_REPLYTO_NAME as current script will generate a .env file which causes an 500 error preventing the site from loading.

Log File: /var/log/apache2/error.log:
The environment file is invalid!
Failed to parse dotenv file. Encountered unexpected whitespace at [Asset Management System].

Fixes # (issue)
See above

Type of change
Please delete options that are not relevant.

[X ] Bug fix (non-breaking change which fixes an issue)
How Has This Been Tested?
Tested in local enviroment with mail being sent to a external email server running postfix.

Patch for whitespace causing HTTP 500 errors.
Patch that adds qoutes around MAIL_FROM_NAME and MAIL_REPLYTO_NAME as current script will generate a .env file which causes an 500 error preventing the site from loading.

Log File: /var/log/apache2/error.log:
The environment file is invalid!
Failed to parse dotenv file. Encountered unexpected whitespace at [Asset Management System].
@DarrenRainey DarrenRainey requested a review from snipe as a code owner November 13, 2024 21:00
Copy link

what-the-diff bot commented Nov 13, 2024

PR Summary

  • Improvement of Value Storage in 'snipeit.sh' Script
    The sed command, which is a utility in the snipeit.sh script, has been updated to better handle the value of $mailfromname. This value is now saved to the .env file but wrapped in single quotes, improving script reliability and data integrity.

  • Enhanced Handling of Reply-to Name in 'snipeit.sh' Script
    Similarly, the sed command has also been updated to manage the $mailreplytoname value more effectively. This modification ensures that the value is saved in the .env file while being wrapped in single quotes, ensuring optimal script performance and data validity.

@snipe snipe merged commit 796a397 into snipe:develop Nov 13, 2024
3 checks passed
Copy link

welcome bot commented Nov 13, 2024

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants