Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify table name in select for models controller #15811

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

snipe
Copy link
Owner

@snipe snipe commented Nov 14, 2024

This fixes an issue where you might get an "ambiguous" query error depending on what you're sorting on in the Asset Models API controller.

@snipe snipe merged commit 70d9ef4 into develop Nov 14, 2024
8 of 9 checks passed
Copy link

what-the-diff bot commented Nov 14, 2024

PR Summary

  • Consistency and Clarity in Code References
    We've improved the readability of our code by consistently prefixing column references with models. This update has been implemented in the index method of AssetModelsController.php. The changes are as follows:
    • model_number is now referenced as models.model_number
    • min_amt is now referenced as models.min_amt
    • eol is now referenced as models.eol
    • created_by is now referenced as models.created_by
    • requestable is now referenced as models.requestable
    • category_id is now referenced as models.category_id
    • manufacturer_id is now referenced as models.manufacturer_id
    • depreciation_id is now referenced as models.depreciation_id
    • fieldset_id is now referenced as models.fieldset_id

This brings homogeneous code structure and makes it easier for upcoming developers to understand and navigate through our code.

@snipe snipe deleted the small_fix_for_embiguous_created_by branch November 14, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant