Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a couple migrate:rollback issues #15840

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

marcusmoore
Copy link
Collaborator

Description

This small PR fixes two issues in the down methods for migrations:

  • created_by wasn't being reverted properly
  • There was an attempt to use varchar when it should be string

I personally rarely use migrate:rollback but allowing it to complete successfully it is 👍🏾

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@marcusmoore marcusmoore requested a review from snipe as a code owner November 18, 2024 20:27
Copy link

what-the-diff bot commented Nov 18, 2024

PR Summary

  • Modification of Data Type in System Setting
    We adjusted the nature of the webhook_endpoint variable in the system's settings. It was initially set to a varchar type (vaguely equivalent to lines of text), but we've updated it to a string type, which is a simpler, more flexible form of representing text and numbers.

  • Alteration in Column Name in User Information
    In the part of the system where users' information is maintained, we have renamed an important attribute. Previously known as user_id, it is now termed created_by. This change reflects a shift in how we intend to reference and utilize this specific attribute.

@snipe snipe merged commit d60ac0c into snipe:develop Nov 19, 2024
9 checks passed
@marcusmoore marcusmoore deleted the fixes/migration-rollbacks branch November 19, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants