Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding colon to password translation string #15850

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Conversation

akemidx
Copy link
Collaborator

@akemidx akemidx commented Nov 19, 2024

Description

Added a colon in the translation for 'password' for emails.
This will allow for easier reading and a more expected view.

Fixes # (issue)
27448

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

@akemidx akemidx requested a review from snipe as a code owner November 19, 2024 22:01
Copy link

what-the-diff bot commented Nov 19, 2024

PR Summary

  • Updated String for Password in Translation File
    The label for the password field has been updated in the system's language file. Previously, it was written as 'Password', but now it has been changed to 'Password:' to include a colon. This small change improves the clarity of user interfaces where this label is used.

@snipe
Copy link
Owner

snipe commented Nov 19, 2024

We should add this in the mail blade, not in the translation string.

@akemidx
Copy link
Collaborator Author

akemidx commented Nov 21, 2024

okay, it is also in the username translation string,

@snipe
Copy link
Owner

snipe commented Nov 21, 2024

It should be in the blade for both

@snipe snipe merged commit feba860 into snipe:develop Nov 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants