Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a ternary for blank emails for mail notifications #15859

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

Godmartinz
Copy link
Collaborator

Description

This adds a ternary operator on the checkedOutTo email check. removing the warning error of ErrorException: Attempt to read property "email" on null

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [ x] Bug fix (non-breaking change which fixes an issue)

@Godmartinz Godmartinz requested a review from snipe as a code owner November 20, 2024 16:32
Copy link

what-the-diff bot commented Nov 20, 2024

PR Summary

  • Improved Handling of Null Cases in getNotifiables Method
    The method getNotifiables has been updated to better deal with instances where checkedOutTo may not have a value (null cases). This ensures the system can still function smoothly even if certain data isn't available.

@Godmartinz Godmartinz changed the title add a ternary for blank emails for mail notifications Adds a ternary for blank emails for mail notifications Nov 20, 2024
@Godmartinz Godmartinz requested review from marcusmoore and snipe and removed request for snipe November 20, 2024 17:53
@snipe snipe merged commit 3a683d8 into snipe:develop Nov 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants