Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Users API update from clearing location_id unnecessarily #15889

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

Godmartinz
Copy link
Collaborator

@Godmartinz Godmartinz commented Nov 26, 2024

Description

This makes updating the location_id conditional only if the location_id key is passed in the PATCH or PUT request (even though you shouldn't use a PUT request most of the time).

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [ x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

Copy link

what-the-diff bot commented Nov 26, 2024

PR Summary

  • Improved Location Update
    This update adds a condition that must be met before the location of items assigned to a user gets modified. This means the system will first confirm there is a 'location_id' present in the request before changing any location data. This act ensures more accurate and reliable location updates.

@snipe
Copy link
Owner

snipe commented Nov 26, 2024

Awesome, ty!

@snipe
Copy link
Owner

snipe commented Nov 26, 2024

@Godmartinz can you retarget this to develop tho? ;)

@Godmartinz Godmartinz changed the base branch from master to develop November 26, 2024 18:30
@Godmartinz
Copy link
Collaborator Author

done 👍

@snipe snipe merged commit 37e091a into snipe:develop Nov 26, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants