Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile view fix #15890

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Mobile view fix #15890

merged 2 commits into from
Nov 26, 2024

Conversation

Godmartinz
Copy link
Collaborator

Description

This fixes the mobile view for assets and users being too narrow and the table not stretching the full width.

Before:
image
After:
image

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [x ] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

@Godmartinz Godmartinz requested a review from snipe as a code owner November 26, 2024 19:01
Copy link

what-the-diff bot commented Nov 26, 2024

PR Summary

  • Simplified Display for Smaller Screens
    The code change removes certain configurations affecting the layout arrangement on screens with maximum width of 992 pixels. This results in a less complex and more fluid display on devices with smaller screens like tablets and mobile phones.

  • Improvement In Artwork Layout for Smaller Screens
    A new media query has been introduced that adjusts the width of certain components on smaller screens. This enhances the visual aspects of certain elements ensuring they appropriately fill the screen.

  • Consistent Layout Enhancement
    The layout has been made consistent by adjusting the 'columns' in the file view.blade.php. This change aims to make the appearance of the pages more uniform and hence improve the user experience.

  • Icon Rendition Improvement
    An unnecessary component in the icon representation in view.blade.php was removed. This will help streamline the visual elements, ensuring better rendering of the icon.

@snipe
Copy link
Owner

snipe commented Nov 26, 2024

Nice!

@snipe snipe merged commit fa80716 into snipe:develop Nov 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants