Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #15901 - re-added required indicator on text and select custom fields #15904

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

snipe
Copy link
Owner

@snipe snipe commented Dec 2, 2024

This should fix a regression introduced in #15552 that was partially fixed in #15573.

Basically, in PR #15552, we changed the CSS to use the CSS selector instead of the CSS class for the HTML form element, however this caused inconsistencies since we were not using the required selector on every form field. I thought we had gotten them all in the PR #15573 but it looks like we missed a few.

On Edit, Before Submitting

Screenshot 2024-12-02 at 3 49 44 PM

On Edit, After Submitting

Screenshot 2024-12-02 at 3 49 32 PM

We still don't seem to be handling required checkboxes and radios correctly on the display, but I'll open a Shortcut for that.

Should fix #15901

@snipe snipe merged commit 2220828 into develop Dec 2, 2024
7 of 9 checks passed
@snipe snipe deleted the fixes/#15901 branch December 2, 2024 15:51
Copy link

what-the-diff bot commented Dec 2, 2024

PR Summary

  • Added 'Required' Attribute to Various Form Fields Conditionally
    This change means that certain fields in a form (like the ones where you input information on a website) will now sometimes need to be filled out, based on some criteria.

  • Updated HTML Structure for Different Input Types in Form
    The code that creates different types of inputs in a form (such as checkboxes, date fields, text boxes, etc.) has been updated to better fit with the rest of the system.

  • Code Readability Enhancement for Form Field Types
    Notes commenting on different parts of the code have been added for a better understanding of various field types. This will make the code easier for others to read and understand.

  • Refined Form Selection Parameters
    In the form selection parameters, the 'required' attribute is now included. This means that when creating a form, there is now an option to make certain fields a requirement to be filled out.

  • Extended 'Required' Attribute to Textarea, Date, and Text Fields
    The 'required' attribute, which was previously added conditionally, is now also added to textarea, date, and text input fields. This means users are required to fill these fields based on certain conditions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant