Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harden asset checkout validation #15912

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

marcusmoore
Copy link
Collaborator

Description

This PR follows up the reverted #15892 and adds the numeric and nullable rules for assigned_user, assigned_asset, and assigned_location.

The previous PR broke asset checkouts via the UI because the added rules didn't include nullable so validation failed since the UI includes the assigned_user, assigned_asset, and assigned_location fields in the submission. I amended the test to account for that.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@marcusmoore marcusmoore requested a review from snipe as a code owner December 2, 2024 20:54
Copy link

what-the-diff bot commented Dec 2, 2024

PR Summary

  • Improved Data Validation:
    • The rules that check and confirm the validity of data in our system have been made better. This change affects the way the system checks users, assets, and location specifications. This update includes more robust checks including numerical values and empty spaces.
  • Enhanced Test Preparation:
    • We've updated our automatic system testing setup. We've created a list of default properties including user, asset, and location that will always be integrated during the testing process.
    • This setup also merges these default properties with the incoming new data. The benefit of this is that it makes our testing processes cleaner and more manageable.
  • Consistent Data Format Changes:
    • The format of various properties - user, asset, and status identifiers - have been updated when sending or receiving data during the checkout process. This promotion of consistency helps in reducing errors and making our system function with more reliability.

@snipe snipe merged commit 1434522 into snipe:develop Dec 19, 2024
9 checks passed
@marcusmoore marcusmoore deleted the bug/harden-checkout-validation-v2 branch December 19, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants