Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the table-responsive div from several index blades #15919

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

Godmartinz
Copy link
Collaborator

@Godmartinz Godmartinz commented Dec 3, 2024

Description

Removes the table-responsive class from several index tables, this allows the dropdown menus to expand further than the table length.

BEFORE:
image

AFTER:
image

These changes were applied to the following index blades of:

  1. Accessories
  2. Predefined Kits
  3. Custom Fields
  4. Status Labels
  5. Asset Models
  6. Categories
  7. Manufacturers
  8. Suppliers
  9. Departments
  10. Locations
  11. Companies
  12. Depreciations

Reports blades:
13. Depreciation
14. Licenses
15. Asset Maintenance
16. Unaccepted Assets
17. Accessories

Fixes #15665

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

Copy link

what-the-diff bot commented Dec 3, 2024

PR Summary

  • Simplification of HTML structure in Blade view files
    The team has removed unnecessary <div class="table-responsive"> wrappers from various Blade view files. This reduces the complexity of the markup, keeping it cleaner and more maintainable.

  • Affected Files:
    These changes have been applied in multiple files, including, but not limited to:

    • accessories/index.blade.php
    • categories/index.blade.php
    • companies/index.blade.php
    • custom_fields/index.blade.php
    • departments/index.blade.php
    • depreciations/index.blade.php
    • kits/index.blade.php
    • locations/index.blade.php
    • manufacturers/index.blade.php
    • models/index.blade.php
    • reports/accessories.blade.php
    • reports/asset_maintenances.blade.php
    • reports/depreciation.blade.php
    • reports/licenses.blade.php
    • reports/unaccepted_assets.blade.php
    • statuslabels/index.blade.php
    • suppliers/index.blade.php
  • Overall Business Impact:
    The major benefit of these changes is a simpler, less cluttered structure of our code. When the codebase is less complex, it becomes easier for developers to understand and further improve the code, thus improving the long-term quality and sustainability of our product. Importantly, these changes have been made without affecting the functionality of our tables or their responsive design features.

@snipe
Copy link
Owner

snipe commented Dec 3, 2024

Did you check this on mobile as well?

@Godmartinz
Copy link
Collaborator Author

Just did, I notice no difference in appearance/functionality.

Copy link
Collaborator

@marcusmoore marcusmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏾

@snipe snipe merged commit 4d3db2a into snipe:develop Jan 6, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants