Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

following docs for prod docker without specifying APP_VERSION will now get latest version as docs say #16008

Closed
wants to merge 4 commits into from

Conversation

AnouarTouati
Copy link
Contributor

The docs here highly encourage not letting APP_VERSION empty as it will get the latest version.

But that is not the case, it is hard coded to v6.1.4 in the .env.docker file and if the version number is removed it will still not get the latest version as docker-compose.yml falls back to v7.0.11.

So this change will allow the user to put a specific version or leave it empty to get the latest version.

Screenshot from 2024-12-29 00-11-30

Copy link

welcome bot commented Dec 29, 2024

💖 Thanks for this pull request! 💖

We use semantic commit messages to streamline the release process and easily generate changelogs between versions. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix if it doesn't have one already.

Examples of commit messages with semantic prefixes:

  • Fixed #<issue number>: don't overwrite prevent_default if default wasn't prevented
  • Added #<issue number>: add checkout functionality to assets
  • Improved Asset Checkout: use new notification method for checkout

Things that will help get your PR across the finish line:

  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

Copy link

what-the-diff bot commented Dec 29, 2024

PR Summary

  • Application Version Update
    The application version information, which was previously specified as a particular value (v7.0.11), has been cleared. This allows for more flexibility in handling updates.

  • Docker Image Tag Modification
    The Docker image tag, which decides the version of the Docker image to be deployed, has been switched from a fixed version number (v7.0.11) to "latest". This means that whenever the system is run, it will automatically use the most recent version of the Docker image.

@AnouarTouati
Copy link
Contributor Author

I split the commits from this PR into three smaller PRs #16009 #16010 #16011 so I am closing this one.

@AnouarTouati AnouarTouati deleted the docker branch December 29, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant