Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed migration causing issues with mariadb #16028

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

marcusmoore
Copy link
Collaborator

This PR amends a migration that was included in #15714 that does not work on older versions of mariadb (v10 and below I believe).

That PR introduced a json column and mariadb (<v11) doesn't like that so this PR changes it to a text type like we have elsewhere in the application.

Some people may have already successfully run the migration and so another migration was created to "change" the column to text. To the best of my knowledge and from testing, if the column is already text then the operation is essentially a no-op so it shouldn't cause any issues "changing" the column from "text" to "text".


Fixes #16015

@marcusmoore marcusmoore requested a review from snipe as a code owner January 6, 2025 22:43
Copy link

what-the-diff bot commented Jan 6, 2025

PR Summary

  • Updated 'options' Column Within the 'report_templates' Table
    Changed the data type of 'options' column from json to text enhancing compatibility with earlier versions of MariaDB.

  • Introduced New Migration File
    A new file 2025_01_06_210534_change_report_templates_options_to_column_text_field.php was added. This enables a persistent change in the type of the 'options' column to text. A key objective behind this move was to foster consistent data handling across multiple database versions.

@marcusmoore marcusmoore changed the base branch from master to develop January 6, 2025 22:43
@snipe snipe merged commit f698f74 into snipe:develop Jan 6, 2025
11 of 12 checks passed
@marcusmoore marcusmoore deleted the fixes/report-template-column branch January 6, 2025 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade error Migrating database
2 participants