Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed acceptance reminder email formatting #16035

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

marcusmoore
Copy link
Collaborator

When hitting the "Re-send Reminder" button on the Unaccepted Assets page (/reports/unaccepted_assets) the email that is sent isn't formatted correctly. This PR fixes that.

The keys are squished:

This is due to the "notes" actually being set to the acceptance itself.

By fixing the parameter order we fix the issue:

Copy link

what-the-diff bot commented Jan 7, 2025

PR Summary

  • Modification in CheckoutAssetMail Function Parameters
    The sequence of input arguments being fed into the 'CheckoutAssetMail' has been altered. In particular, the parameter related to 'log item notes' which was previously preceding the 'acceptance' parameter, has now been repositioned to the end of this sequence.

@snipe
Copy link
Owner

snipe commented Jan 7, 2025

I thought we already fixed this?

@snipe snipe merged commit 63853db into snipe:develop Jan 7, 2025
8 of 9 checks passed
@marcusmoore
Copy link
Collaborator Author

The code around this was modified recently and the bug might have been introduced in the process.

@marcusmoore marcusmoore deleted the fixes/unaccepted-assets-reminder branch January 7, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants