Better hide reset password functionality for LDAP users #16091
Merged
+37
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were already disallowing LDAP users to save new passwords, but there were a few places where we didn't hide the buttons. (It would redirect with error on save, and didn't actually save the password, but it was a clunkier user experience.
This now does a better job of hiding those elements if the user has
ldap_import
set to1
on their account.TODO: We should probably come up with a better way of explaining what
ldap_import
actually does in the modern world. Really, it just determines whether or not the user can edit their password, and we could probably do a better job of explaining that instead of the old "LDAP Enabled" text. In fact, perhaps change the actual fieldname to reflect what this actually does.