Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace calls to Form::password #16107

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Replace calls to Form::password #16107

merged 2 commits into from
Jan 22, 2025

Conversation

marcusmoore
Copy link
Collaborator

This PR replaces calls to Form::password() with plain old html.

Pages Affected

@what-the-diff What The Diff
Copy link

what-the-diff bot commented Jan 22, 2025

PR Summary

  • Improvement to Password Fields in LDAP Settings
    Modified the file resources/views/settings/ldap.blade.php to enhance how password fields are represented. The update swaps {{ Form::password(...) }} for a standard <input> HTML element for the ldap_pword parameter.

  • Password Fields Update in User Setup
    Altered the resources/views/setup/user.blade.php to update the representation of password fields. The new code replaces {{ Form::password(...) }} with the standard <input> HTML elements for both password and password_confirmation fields.

@marcusmoore marcusmoore marked this pull request as ready for review January 22, 2025 00:26
@marcusmoore marcusmoore requested a review from snipe as a code owner January 22, 2025 00:26
snipe
snipe reviewed Jan 22, 2025
View reviewed changes
resources/views/settings/ldap.blade.php Outdated
@@ -324,7 +324,7 @@
{{ Form::label('ldap_pword', trans('admin/settings/general.ldap_pword')) }}
</div>
<div class="col-md-8">
{{ Form::password('ldap_pword', ['class' => 'form-control', 'autocomplete' => 'off', 'onfocus' => "this.removeAttribute('readonly');", ' readonly']) }}
<input class="form-control" type="password" name="ldap_pword" id="ldap_pword" value="" autocomplete="off" onfocus="this.removeAttribute('readonly');" readonly="">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be just readonly, not readonly=""

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I think that was from the copy/paste from dev tools actually but yeah, it only needs to be readonly. Fixed.

snipe
snipe requested changes Jan 22, 2025
View reviewed changes
Copy link
Owner

@snipe snipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change

@snipe snipe merged commit d696ed8 into snipe:develop Jan 22, 2025
8 of 9 checks passed
@marcusmoore marcusmoore requested a review from snipe January 22, 2025 17:28
@marcusmoore marcusmoore deleted the chore/migrate-password-helper branch January 22, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snipe snipe Awaiting requested review from snipe snipe is a code owner

Assignees
No one assigned
Labels
frontend ldap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcusmoore @snipe