Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential attempt to divide by zero in transformer #16116

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

marcusmoore
Copy link
Collaborator

This PR adds a guard against dividing by zero in the DepreciationReportTransformer.

Copy link

what-the-diff bot commented Jan 22, 2025

PR Summary

  • Updated Asset Depreciation Conditions
    The logic in our asset depreciation processing procedures has been updated. It now verifies whether an asset's depreciation timeframe is longer than zero months before continuing with the depreciation process.

  • Added New Test Case for Zero Depreciation Months
    To make certain our system can properly handle instances where an asset's depreciation period is set as zero months, we've integrated a new test case. This helps us ensure the consistency and reliability of our system.

@snipe snipe merged commit 802fcba into snipe:develop Jan 22, 2025
9 checks passed
@marcusmoore marcusmoore deleted the bug/sc-20259 branch January 22, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants