Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent undefined array key in asset observer #16118

Merged

Conversation

marcusmoore
Copy link
Collaborator

@marcusmoore marcusmoore commented Jan 22, 2025

This PR simply adds an array_key_exists to help prevent "undefined array key" exceptions.

I haven't tracked down exactly how this happens but adding an array_key_exists check should prevent the issue.

Copy link

what-the-diff bot commented Jan 22, 2025

PR Summary

  • Improved Error Handling in AssetObserver
    The PR contains an update to the updating method in AssetObserver. Specifically, it now includes a condition to verify if an attribute exists before comparing its values. This enhancement prevents possible errors related to non-existent indexes, ultimately improving the robustness and reliability of the system.

@snipe snipe merged commit e53ed23 into snipe:develop Jan 22, 2025
8 of 9 checks passed
@marcusmoore marcusmoore deleted the fixes/undefined-key-in-asset-observer branch January 27, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants