Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QR Code Settings Check #16149

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

spencerrlongg
Copy link
Collaborator

Adds a check and error message to the QR code sheet if QR codes are enabled but 'none' is selected as the type.

image

Copy link

what-the-diff bot commented Jan 29, 2025

PR Summary

  • Streamline QR Code Interaction in AssetsController
    The getQrCode method within AssetsController.php was updated. This now incorporates a safety check, meaning it will return false if the QR code type is erroneously set to 'none'. This enhancement makes the system more robust by handling anomalous situations more sophisticatedly.

  • Augment UI Feedback with Warning Messages
    The user interface will now exhibit a warning message, decorated in intuitive red color, if QR Codes are active but set to 'none'. This happens in labels.blade.php.

  • Optimized QR Code Display Condition
    In the same labels.blade.php file, the logic has been revised to only display the QR code when a valid QR code type is chosen, improving user experience and mitigating potential confusion.

  • Introduce new Translatable String for Invalid QR Settings
    A new language string was introduced in general.php that handles situations where the QR code settings might be invalid. This inclusion supports better localization and usability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant