Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "Reminder" to subject line of follow up asset checkout emails #16156

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from

Conversation

marcusmoore
Copy link
Collaborator

This PR updates the subject line for emails sent via the "Reports: Unaccepted Assets page" (/reports/unaccepted_assets):
Unaccepted Assets page


Since the same Mailable, CheckoutAssetMail, is used when the initial email is sent and when the buttons above are clicked receivers of the email may think additional assets have been checked out to them.

This differentiates the initial and follow up emails by prefixing Reminder: to the subject line:

Situation Result
Initial Email image
Additional Emails image

My implementation included adding another parameter, $firstTimeSending = true, to an already long parameter list and I don't love that but it works.

I also added tests for different logic branches in the controller method.

Copy link

what-the-diff bot commented Jan 30, 2025

PR Summary

  • Improved Email Notifications For Reports
    The email logic within the reports section has been adjusted to send reminder notifications more effectively. Emails are now tailored based on it being the first alert or a subsequent reminder.

  • Enhancements To The Asset Checkout System
    A key component that controls asset checkout has been improved to differentiate between a first alert and a reminder. This enhancement results in more accurate and efficient notifications.

  • Updated Email Language
    New language keys have been added to the email system to accommodate the improved reminder system. This enables the creation of more fitting email subjects when reminders are sent.

  • Inclusion Of New State In The Checkout System
    The checkout state now has an additional, 'accepted' status which denotes a completed checkout procedure. This enhancement improves the system's ability to accurately track and record checkout statuses.

  • Added Unit Tests For Reminder System
    The new reminder system now includes dedicated unit tests. These tests ensure the proper functioning of the reminder system and identify any unexpected behaviour efficiently.

  • Refined Existing Tests
    Minor changes have been made to existing tests to align them with the updated mail logic, ensuring consistent evaluation of the email notification system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant