-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added "Reminder" to subject line of follow up asset checkout emails #16156
base: develop
Are you sure you want to change the base?
Added "Reminder" to subject line of follow up asset checkout emails #16156
Conversation
PR Summary
|
This PR updates the subject line for emails sent via the "Reports: Unaccepted Assets page" (
/reports/unaccepted_assets
):Since the same Mailable,
CheckoutAssetMail
, is used when the initial email is sent and when the buttons above are clicked receivers of the email may think additional assets have been checked out to them.This differentiates the initial and follow up emails by prefixing
Reminder:
to the subject line:My implementation included adding another parameter,
$firstTimeSending = true
, to an already long parameter list and I don't love that but it works.I also added tests for different logic branches in the controller method.