Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add licenses api parameters and fix a missing variable in license view. #9889

Merged
merged 3 commits into from
Oct 29, 2021

Conversation

ncareau
Copy link
Contributor

@ncareau ncareau commented Aug 1, 2021

Description

Added 2 parameters in the license API in order to filter maintained licenses and licenses that expires or not.

Also added a missing item that wasn't shown in the license view, the maintained field was not displayed.

I didn't find where i could change the API documentation in the repo. If you could point me in the right direction i'll make the necessary changes (add both expires and maintained parameters.)

As mentionned in #9834, this PR is for the develop branch. I made changed to develop-v6-integration in #9890.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Manual test with docker

Test Configuration:

  • Used the docker with default configuration.

Checklist:

</strong>
</div>
<div class="col-md-8">
{{ $license->maintained ? 'Yes' : 'No' }}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably use the localization strings here instead of hard-coding Yes/No. I believe you can find them as general.yes and general.no

@snipe
Copy link
Owner

snipe commented Oct 29, 2021

I'll fix it - no worries :)

@snipe snipe merged commit 645529b into snipe:develop Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants