Remove the use of the FMDB dependency in SQLiteEventStore (close #823) #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matus-tomlein
force-pushed
the
issue/823-remove_fmdb
branch
from
52f6ad8 to
68c84fa
Compare
matus-tomlein
force-pushed
the
issue/823-remove_fmdb
branch
from
68c84fa to
ad68b8e
Compare
mscwilson
approved these changes
Oct 16, 2023
| _ = eventStore.removeAllEvents() | ||
| XCTAssertEqual(eventStore.count(), 0) | ||
| } | ||
|
|
||
| func testSQLiteEventStoreCreateSQLiteFile() { | ||
| _ = SQLiteEventStore(namespace: "aNamespace") | ||
| let eventStore = createEventStore("aNamespace") | ||
| _ = eventStore.count() |
There was a problem hiding this comment.
This is actually no longer necessary – I added that because at one time I wanted to initialize the database lazily (only create it on the first database call), but I have later changed my mind and create it during initialization. I have removed this from the tests, thanks for pointing out!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #823
This PR removes the FMDB dependency in favor of accessing the database directly using the
sqlite3calls. The calls are wrapped in aDatabaseclass. Every call uses a new database connection.The
SQLiteEventStoreclass wraps theDatabaseclass and handles concurrency using a serial dispatch queue. All the calls in theSQLiteEventStoreare synchronous as before.