createTracker now returns non-optional TrackerController
#848
Conversation
snowplowcla
added
the
cla:no
|
Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://docs.snowplowanalytics.com/docs/contributing/contributor-license-agreement/ to learn more and sign. Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks. |
Sources/Snowplow/Snowplow.swift
Outdated
There was a problem hiding this comment.
This is the meat of the PR 🍖
Signed! 👇 
|
There was a problem hiding this comment.
Thank you for the contribution @Kymer! As you said in the issue, making the TrackerController was an oversight during the Swift migration of the codebase. We'll make sure that this gets into the v6 release!
Just one small thing – could you please rebase your changes on top of the release/6.0.0 branch? There seem to be some conflicts.
Kymer
force-pushed
the
feature/remove-unnecessary-optionality
branch
3 times, most recently
from
46a7d60 to
7243ee8
Compare
Done! |
Kymer
force-pushed
the
feature/remove-unnecessary-optionality
branch
from
7243ee8 to
d37a1d6
Compare
Kymer
force-pushed
the
feature/remove-unnecessary-optionality
branch
from
d37a1d6 to
46838d3
Compare
jbeemster
added
cla:yes
This PR fixes #847. All tests compile and run fine: everything was green except for the
IntegrationTests. These fail because I don't have a local service running. I assume I need to set-up Snowplow Micro to get this working?Anyway, this is a very small change. Having the tests compile gave me enough confidence to open this PR.