Fix bundle path check to handle symbolic links (close #858) #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowplowcla
added
the
cla:yes
mylifeasdog
force-pushed
the
issue/858-bundle-path-check-for-modularized-app
branch
3 times, most recently
from
8aa3f5b to
ce45e4a
Compare
mylifeasdog
force-pushed
the
issue/858-bundle-path-check-for-modularized-app
branch
from
ce45e4a to
1b287e3
Compare
mylifeasdog
changed the title
matus-tomlein
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
LGTM! It works nicely, thank you for the contribution @mylifeasdog! We will release it in the upcoming version 6.0.0 release of the tracker.
matus-tomlein
force-pushed
the
release/6.0.0
branch
from
43f6453 to
63470ba
Compare
matus-tomlein
changed the title
matus-tomlein
pushed a commit
that referenced
this pull request
Jan 19, 2024
matus-tomlein
pushed a commit
that referenced
this pull request
Jan 19, 2024
mylifeasdog
deleted the
issue/858-bundle-path-check-for-modularized-app
branch
matus-tomlein
pushed a commit
that referenced
this pull request
Feb 1, 2024
Could you inform me about the expected release window for version 6.0.0? This will help me decide whether to implement alternative solutions or wait for the official update, depending on the timeline. Thank you! |
|
Hi @mylifeasdog, the plan is to release it today! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #858 concerning the Snowplow SDK's bundle path handling in modularized iOS apps. The current
UIViewControllerextension's method for tracking screen views fails on real iOS devices due to not accounting for the symbolic link between/private/var/and/var/.The fix involves updating
sp_viewDidAppearto useresolvingSymlinksInPath(), ensuring the bundle paths for both the main app and its frameworks are standardized. This method resolves/private/var/to/var/, aligning framework paths with the main app bundle. This change guarantees accurate tracking of view controllers across all frameworks on iOS devices.