Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.12 to CI tests (close #356) #355

Merged

Conversation

edgarrmondragon
Copy link
Contributor

No description provided.

@snowplowcla
Copy link

Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://docs.snowplowanalytics.com/docs/contributing/contributor-license-agreement/ to learn more and sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

@snowplowcla snowplowcla added the cla:no [Auto generated] Snowplow Contributor License Agreement has not been signed. label Feb 6, 2024
@edgarrmondragon
Copy link
Contributor Author

I signed it!

@snowplowcla
Copy link

Confirmed! @edgarrmondragon has signed the Contributor License Agreement. Thanks so much.

@snowplowcla snowplowcla added cla:yes [Auto generated] Snowplow Contributor License Agreement has been signed. and removed cla:no [Auto generated] Snowplow Contributor License Agreement has not been signed. labels Feb 6, 2024
@edgarrmondragon edgarrmondragon marked this pull request as ready for review February 6, 2024 23:19
@coveralls
Copy link

coveralls commented Feb 7, 2024

Coverage Status

coverage: 95.946%. remained the same
when pulling b93d245 on edgarrmondragon:ci/test-python3.12
into b29a57d on snowplow:master.

@Jack-Keene
Copy link
Contributor

Hi @edgarrmondragon, thanks for making a contribution to the Snowplow Python Tracker!

There's a couple of changes required before we add can add this to a release, namely adding the new version to the tests and the Dockerfile. See this PR for adding support to Python 3.11 for an example.

@edgarrmondragon
Copy link
Contributor Author

Hi @edgarrmondragon, thanks for making a contribution to the Snowplow Python Tracker!

There's a couple of changes required before we add can add this to a release, namely adding the new version to the tests and the Dockerfile. See this PR for adding support to Python 3.11 for an example.

Thanks for the pointer @Jack-Keene! I've added 3.12 where it was missing.

@Jack-Keene Jack-Keene changed the base branch from master to release/1.0.2 February 20, 2024 12:12
Copy link
Contributor

@Jack-Keene Jack-Keene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Jack-Keene Jack-Keene changed the title Test with Python 3.12 Add Python 3.12 to CI tests (close #356) Feb 26, 2024
@Jack-Keene Jack-Keene merged commit db531d3 into snowplow:release/1.0.2 Feb 26, 2024
9 checks passed
@edgarrmondragon edgarrmondragon deleted the ci/test-python3.12 branch February 26, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes [Auto generated] Snowplow Contributor License Agreement has been signed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants