-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3.12 to CI tests (close #356) #355
Add Python 3.12 to CI tests (close #356) #355
Conversation
Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://docs.snowplowanalytics.com/docs/contributing/contributor-license-agreement/ to learn more and sign. Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks. |
I signed it! |
Confirmed! @edgarrmondragon has signed the Contributor License Agreement. Thanks so much. |
Hi @edgarrmondragon, thanks for making a contribution to the Snowplow Python Tracker! There's a couple of changes required before we add can add this to a release, namely adding the new version to the tests and the Dockerfile. See this PR for adding support to Python 3.11 for an example. |
2f766fe
to
b93d245
Compare
Thanks for the pointer @Jack-Keene! I've added 3.12 where it was missing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No description provided.