This repository has been archived by the owner on May 29, 2018. It is now read-only.

Gedit find field, has red background and foreground color. #355

Open

demoy opened this issue May 18, 2016 · 1 comment

demoy commented May 18, 2016 •

edited

Loading

the GNOME/GTK version that is on your system
Gnome 3.20
which Linux distribution you are running
Fedora Rawhide
the version of Paper you are using
at commit 266

In Gedit 3.20 when ctrl-f is unable to find a text, the find-field text is highlighted "red" and background is highlighted "blue" in Adwaita.

Paper currently makes the background "red" and the text "red", making it invisible.

JoeyCorleone pushed a commit to JoeyCorleone/paper-gtk-theme that referenced this issue


          Fix fg/bg same color

5c28f0d

Foreground and background colors should be different and readable.

Approach for dynamically changing text color based on a background
color taken from:
http://thesassway.com/intermediate/dynamically-change-text-color-based-on-its-background-with-sass

Consider replacing this commit with
http://codepen.io/sebastianekstrom/pen/avDjh
which should create better fg colors based on the bg color.

Resolves: snwh#355

JoeyCorleone pushed a commit to JoeyCorleone/paper-gtk-theme that referenced this issue


          Fix fg/bg same color

4ac58d1

Foreground and background colors should be different and readable.

Approach for dynamically changing text color based on a background color taken from:
http://thesassway.com/intermediate/dynamically-change-text-color-based-on-its-background-with-sass

Consider replacing this commit with http://codepen.io/sebastianekstrom/pen/avDjh
which should create better fg colors based on the bg color.

Resolves: snwh#355

JoeyCorleone pushed a commit to JoeyCorleone/paper-gtk-theme that referenced this issue


          Fix fg/bg same color

fc81d7c

Fg/bg colors should be different in entries (i.e. search entry in gedit).

To make the text readable, the fg color is dynamically set using this approach:
http://thesassway.com/intermediate/dynamically-change-text-color-based-on-its-background-with-sass

Consider using the approach given at https://gist.github.com/jlong/f06f5843104ee10006fe
which promises even better fg color determination.

Resolves: snwh#355

JoeyCorleone pushed a commit to JoeyCorleone/paper-gtk-theme that referenced this issue


          Fix fg/bg same color

f599aff

Fg/bg colors should be different in entries (i.e. search entry in gedit).

To make the text readable, the fg color is dynamically set using this approach:
http://thesassway.com/intermediate/dynamically-change-text-color-based-on-its-background-with-sass

Consider using the approach given at https://gist.github.com/jlong/f06f5843104ee10006fe
which promises even better fg color determination.

Resolves: snwh#355, snwh#383

JoeyCorleone mentioned this issue

Fix #355: Text not readable on error in entry (fg==bg) #395

Open

evilhamsterman commented Jan 26, 2017

I think this is a duplicate of my issue #313

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.