Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS ServiceAccountToken not accessible. #871

Closed
wants to merge 2 commits into from

Conversation

tektite-io
Copy link
Contributor

What this does

AWS ServiceAccountToken is not readable by the snyk-monitor process.
Using fsGroup and projected volume to solve the issue.

See similar problem: kubernetes-sigs/external-dns#1185

@tektite-io tektite-io requested a review from a team as a code owner September 15, 2021 16:42
@ivanstanev ivanstanev self-assigned this Sep 16, 2021
Copy link
Contributor

@ivanstanev ivanstanev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! I was wondering if you only meant to submit the fsGroup change?

Comment on lines +179 to +185
{{- if .Values.volumes.projected.serviceAccountToken }}
- name: token-vol
projected:
sources:
- serviceAccountToken:
path: token
{{- end }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tektite-io I was wondering if this volume also needs to be mounted with a volumeMount? The example in the docs both declares the volume and a volumeMount - https://kubernetes.io/docs/concepts/storage/volumes/#example-configuration-secret-downwardapi-configmap
And if we have to mount this volume, where should it go?

Also, it looks like token expires by default after 1 hour according to the docs. How should we handle this?

@snyksec
Copy link

snyksec commented Sep 17, 2021

🎉 This issue has been resolved in version 1.66.10 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants