[READY] issue-128 - Adding golden files for template validation on openwrt #129
Conversation
| @@ -21,7 +22,7 @@ wired: | |||
| networks: | |||
| # interface names cant have special characters | |||
| - name: 'mgmt' | |||
| ifname: 'eth1.103 eth1.503' | |||
| ifname: 'eth1' | |||
There was a problem hiding this comment.
I changed this in the example so when Im building the openwrt imgs I dont have to setup a vlan locally. I usually forget to do that and then spend a bit figuring out why I cant connect
sarcasticadmin
force-pushed
the
sa/issue-128
branch
from
81f8141 to
53181b4
Compare
sarcasticadmin
changed the title
There was a problem hiding this comment.
Generally looks god. I understand about the ifname in the test environment for now, but let's make sure we change it back and test before the show.
gomplateingnore should probably be *.sw? because if a .swp file exists and vi crashes again on the same file, you get .swo, .swn, ...
|
@owendelong ya i actually use a completely different Thats a good idea, Ill update the |
Gomplate isnt able to identify files that end in something other than there expected file extension. Renaming the secrets example for openwrt so tests work without the need to create the openwrt.yaml file
sarcasticadmin
force-pushed
the
sa/issue-128
branch
from
53181b4 to
263d00c
Compare
|
Merging this. Will also capture new gomolate and test.sh into #130 . This looks good @sarcasticadmin thank you! |
|
@kylerisse thanks! Ill keep an eye out the additions to #130 |
Description of PR
@owendelong @kylerisse @davidelang
Related to: #128
Golden files will now be used to validate the output of
gomplatefor the openwrt configs. Some of the work that makes this possible was just merged into master forgomplate. Mainly: hairyhenderson/gomplate#468 So Ill be waiting eagerly for a new version to drop. For now it requires building thegomplatebinary directory withgo getSpecific commit that enabled this functionality was: d1873444c90e68b5e8ba7492fb83abd36d7ab0ea
Previous Behavior
No automated testing for generated files
New Behavior
openwrt.yaml.exampletoopenwrt-example.yaml(see commit message).gomplateignorefile to make sure it doesnt incldue.swpif you have a template open in another windowTests
How was this PR tested?
If it returns 0 then there's not a diff from the
./tmpdir and your templates match!