Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Crashes related to Concurrency #776

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixing Crashes related to Concurrency #776

wants to merge 1 commit into from

Conversation

Harsh5488
Copy link
Contributor

• Using ConcurrentHashMap for multi-threaded environment

• Making clearAcks() public for clearing acknowledgement when needed

@Harsh5488
• Using ConcurrentHashMap for multi-threaded environment
c3ad90d 
• Making clearAcks() public for clearing acknowledgement when needed
@Harsh5488
Copy link
Contributor Author

Harsh5488 commented Jan 4, 2025 •
edited
Loading

It can solve the issues related to the concurrency
@darrachequesne Please review and merge the changes

@seven4pl
Copy link

@Harsh5488 good job! I had a similar problem with clearing the queue.

@darrachequesne +1 for public clearAcks

@Harsh5488
Copy link
Contributor Author

@darrachequesne
Could you please provide more information on
Why to make the clearAcks() function to be private and called on onclose(String reason) function?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darrachequesne darrachequesne darrachequesne left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Harsh5488 @seven4pl @darrachequesne